Expose terminalbench in run-eval workflow#2360
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
API breakage checks (Griffe)Result: Passed |
Agent server REST API breakage checks (OpenAPI)Result: Failed Log excerpt (first 1000 characters) |
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟢 Good taste
Simple, straightforward configuration change. Adds terminalbench to workflow choices and updates skill docs. Follows existing patterns, tested with smoke run. LGTM! 🚀
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟢 Good taste
Simple, straightforward configuration change. Adds terminalbench to workflow choices and updates skill docs. Follows existing patterns, tested with smoke run. LGTM! 🚀
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟢 Good taste
The code changes are simple and correct. Appropriately kept in draft until the downstream workflow exists. The 404 error you documented confirms the integration isn't complete yet.
Verdict: ✅ Code is solid, just needs the full stack to work before merging.
Summary
terminalbenchto the manualrun-evalworkflow choicesDetails
benchmark=terminalbench,eval_limit=5,sdk_ref=main,eval_branch=openhands/terminalbench-ci-490, andbenchmarks_branch=openhands/terminalbench-ci-490.OpenHands/evaluationand benchmark-side Harbor fixes inOpenHands/benchmarks.Testing
Evidence
Verification link: View conversation
Follow-up investigation: the previously cited terminalbench smoke run did not complete end-to-end, so this PR is being moved back to draft pending real live-run evidence.
$ gh run view 22823734279 --repo OpenHands/software-agent-sdk --json status,conclusion,displayTitle,url {"conclusion":"success","displayTitle":"Run Eval (terminalbench) Smoke test for OpenHands/benchmarks#490","status":"completed","url":"https://github.com/OpenHands/software-agent-sdk/actions/runs/22823734279"} $ gh run view 22823745521 --repo OpenHands/evaluation --json status,conclusion,displayTitle,url {"conclusion":"success","displayTitle":"Eval Job (terminalbench) Smoke test for OpenHands/benchmarks#490","status":"completed","url":"https://github.com/OpenHands/evaluation/actions/runs/22823745521"} $ # Datadog pod logs for eval-22823745521-claude-son* service:python [2026-03-08 15:11:16 UTC] Benchmark: terminalbench [2026-03-08 15:11:16 UTC] Dispatching terminalbench build for SDK commit: 77c68ccfd7bdffb27be88e8793f76cafc45faf9d [2026-03-08 15:11:17 UTC] ERROR: Benchmarks build dispatch failed (status 404): {"message":"Not Found","documentation_url":"https://docs.github.com/rest/actions/workflows#create-a-workflow-dispatch-event","status":"404"} [2026-03-08 15:11:17 UTC] Deleted temporary branch: dispatch-22823745521The GitHub Actions runs only proved that the workflow dispatch/deploy path was reachable. Datadog shows the orchestration failed before the evaluation phase, so there was no completed benchmark run, no uploaded results archive, and no Slack success notification.
Likely root cause:
OpenHands/evaluationcurrently derives the benchmark build workflow name asbuild-{benchmark}-images.yml, which becomesbuild-terminalbench-images.yml. That workflow file does not exist onOpenHands/benchmarks(including branchopenhands/terminalbench-ci-490), so the dispatch returns HTTP 404.Checklist